Fix order of heatmap z-data#1833
Conversation
|
Hmm. We'll have to check with if this is consistent with non-gl |
|
@etpinard yes, we do |
|
but on https://github.com/plotly/plotly.js/blob/master/src/traces/heatmap/hover.js#L38 we set ny = index[1]
nx = index[0] |
|
Not sure where do we use |
|
@etpinard yes, these cases are for regular |
@etpinard looks consistent to me? Anyway, the convention is meant to match the way a matrix is printed: so the first index is row (y) and the second index is column (x) @dfcreative the How about covering the relevant cases with tests, then we don't have to argue about this! |
|
It would be nice to fix this thing in |
|
Supersedes by #1884 |
Should fix #1825
If I get it right, we have rows layout
z: [[x,x,x,x], [x,x,x,x], ...], meaning that to retrieve a value we callz[y][x], notz[x][y].